Taken from the large Puppet upgrade steps: (https://puppet.com/docs/pe/2019.8/upgrading_pe.html#upgrade_large)
From the before you begin section: "Ensure you have a valid admin RBAC token in order to upgrade compilers or a replica."
Followed by these steps in 5 and 6:
puppet infrastructure upgrade compiler <COMPILER_FQDN> --token-file <PATH_TO_TOKEN>
puppet infrastructure upgrade replica <REPLICA_FQDN> --token-file <PATH_TO_TOKEN>
We were failing on Step 4. Which to us did not seem to marry up that we hadn’t done a step because there was no prompt in 4 to provide a Token path.
I think your documentation would be clearer if you made it an explicit instruction before step 4.