Uploaded image for project: 'Facter'
  1. Facter
  2. FACT-1394

Warning printed when 'ip route show' output contains "linkdown"

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • FACT 3.1.5
    • FACT 3.6.0
    • None
    • Debian Sid with PC1 install of Puppet 4.x and puppet-agent latest versions from jessie apt repo (includes facter 3.1.5)

    • Bug Fix
    • Facter no longer prints a spurious warning when 'linkdown' is present in routing table entries

    Description

      When there are network links which are configured but down "ip route show" appends "linkdown" to the output of those routes. e.g.:

      # ip ro sho
      default via 192.168.1.1 dev eth2
      192.168.0.0/24 dev eth0  proto kernel  scope link  src 192.168.0.1 linkdown
      192.168.1.0/24 dev eth2  proto kernel  scope link  src 192.168.1.133
      192.168.2.0/24 dev eth1  proto kernel  scope link  src 192.168.2.1 linkdown
      

      This causes facter to print a warning on every puppet agent run, or whenever facter is run separately:

        Warning: Facter: Could not process routing table entry: Expected a destination followed
      by key/value pairs, got '192.168.0.0/24 dev eth0 proto kernel  scope link  src
      192.168.0.1 linkdown'
        Warning: Facter: Could not process routing table entry: Expected a destination followed
      by key/value pairs, got '192.168.2.0/24 dev eth1 proto kernel  scope link  src
      192.168.2.1 linkdown'
      

      Facter should probably cope with such eventualities, possibly by just ignoring lines with "linkdown" in them. Happy to provide a simple patch to do this if that would be the desired behaviour

      Attachments

        Issue Links

          Activity

            People

              branan Branan Riley
              legooolas David Gardner
              Votes:
              6 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support