Details
-
Improvement
-
Status: Resolved
-
Normal
-
Resolution: Fixed
-
None
-
None
-
None
-
Agent
-
2
-
Agent 2017-04-05
-
No Action
Description
In FACT-1442 the regular expression used to validate the user identity from facter on windows was modified to be more broad. This was to expedite the CI pipelines passing due to Windows 10 being added. However the regex may be too broad and there value is never actually verified.
This ticket should;
- Review the regex and find one that's more specific to stop false positives (as per the comments in https://github.com/puppetlabs/facter/pull/1358#discussion_r68339551)
- Investigate whether it is possible to verify that the value returned from facter is actually true
Attachments
Issue Links
- relates to
-
IMAGES-360 Create JJB for Packer Image Acceptance Testing
-
- Resolved
-
-
FACT-1442 facter/acceptance/test/facts/window.rb fails on windows 10 x86 and x64 platforms
-
- Resolved
-
- links to