Uploaded image for project: 'Facter'
  1. Facter
  2. FACT-1910

Mountpoint fact only shows tmpfs and physical mounts

    Details

    • Template:
    • Team:
      Night's Watch
    • Story Points:
      2
    • Sprint:
      PR - 2019-06-12, PR - 2019-06-25
    • Method Found:
      Needs Assessment
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      This removes the check that the returned mount points are physical
      devices or temporary filesystems, and instead will return mount points
      for all mounts on the system.

      Skip over any mount for /proc or /sys

      This adds a check to skip the mount
      point if it is mounted under the proc or sys directories. It keeps the
      tmpfs check to prevent breaking any code that looks for the
      currently-returned tmpfs mount information under these directories.
      Show
      This removes the check that the returned mount points are physical devices or temporary filesystems, and instead will return mount points for all mounts on the system. Skip over any mount for /proc or /sys This adds a check to skip the mount point if it is mounted under the proc or sys directories. It keeps the tmpfs check to prevent breaking any code that looks for the currently-returned tmpfs mount information under these directories.
    • QA Risk Assessment:
      Needs Assessment

      Description

      While running puppet I noticed that overlayfs mountpoints are not being picked up by facter. Looking through the code it appears that only physical and tmpfs mounts are currently being loaded into the mountpoint facts (https://github.com/puppetlabs/facter/blob/master/lib/src/facts/linux/filesystem_resolver.cc#L79-L82).

       

      For me, the expected return for the mountpoint facts are all mount points, not just physical or tmpfs mounts. It appears that others have a similar desire (FACT-1519). Is it possible to remove this check? It was necessary when the partition data was populated within the filesystem_resolver::collect_mountpoint_data function, but it has been since moved to a separate function and is no longer necessary. This was also the original suggestion for FACT-1418.

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  oana.tanasoiu Oana Tanasoiu
                  Reporter:
                  jvoss Joseph Voss
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Zendesk Support