Details
-
Bug
-
Status: Resolved
-
Normal
-
Resolution: Fixed
-
FACT 3.13.1
-
None
-
Night's Watch
-
3
-
PR - 2019-06-25, PR - 2019-07-10
-
Needs Assessment
-
Bug Fix
-
Previously, facter made the assumption that `ip route show` output has a key/value format. There are configurations for which this format is not applicable, causing facter to throw warnings. This assumption has been now removed.
-
Needs Assessment
Description
The facter module fails to parse entries from `ip show route` if the line has an even number of words but is not preceded with one of the known route types. The restriction to have an even number of words was added as part of FACT-1282 however its not clear from the bug report or the pull request why routes preceded with a route type should have an even number of words however normal entries don't.
It seems that an assumption was made which assumed all entries emitted by `ip show route` are key value pairs however this is not the case as show by FACT-1394 and my current case which has an entry as follows (notice the option `mtu lock 1450`)
192.168.250.22 via 192.168.1.1 dev enx0050b6a21be3 mtu lock 1450
We are also tracking this issue via https://phabricator.wikimedia.org/T222356
