autofs mountpoints being mounted by facter

After updating to facter 3.11.9 we started experiencing issues caused by the regular mounting and unmounting of automount filesystems. We traced the cause back to facter and found that it was triggering a mount of . This seems to be related to the change made in FACT-1910 (0f0d8f4df70f886ec7ae86f65a24909a4f20b0f7/lib/src/facts/linux/filesystem_resolver.cc). The auto mount is triggered by stating the mount dir to get the size and available space.

Skipping non-physical mountpoints was a good catch all of a lot of synthetic filesystems which could introduce other problems problems and so it seems it will now be required to maintain a list of mount types to ignore.

The change should be reverted, autofs should be added as a skipped mtype (as with tempfs) or you should not stat autofs mountpoints.