Uploaded image for project: 'Facter'
  1. Facter
  2. FACT-2618

Incorrect log format on non-executable external fact scripts

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: FACT 3.14.9
    • Fix Version/s: FACT 3.14.10
    • Component/s: None
    • Labels:
      None
    • Template:
    • Acceptance Criteria:
      Hide

      Facter should output logs correctly when external fact scripts aren't executable.

      Show
      Facter should output logs correctly when external fact scripts aren't executable.
    • Team:
      Night's Watch
    • Method Found:
      Customer Feedback
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      If an external fact script cannot be executed, Facter 3.14.9's logging will not indicate what happened, and instead outputs `error while processing "%1%" for external facts: %2%`. This is fixed in Facter 3.14.10, which will output the reported error.
      Show
      If an external fact script cannot be executed, Facter 3.14.9's logging will not indicate what happened, and instead outputs `error while processing "%1%" for external facts: %2%`. This is fixed in Facter 3.14.10, which will output the reported error.
    • QA Risk Assessment:
      Needs Assessment

      Description

      Ciprian Badescu in https://github.com/puppetlabs/facter/commit/76a7bab5c75ff0b1b6a46cc7242582c24adf701d :

      Before this change, the log message format is wrong and the following is logged in case external facts file is not proper executable:

      2020-04-09 15:07:49.499276 ERROR puppetlabs.facter - error while processing "%1%" for external facts: %2%
      

      After this fix, the proper message will be logged:

      2020-04-09 15:10:49.546980 ERROR puppetlabs.facter - error while processing "/opt/puppetlabs/facter/facts.d/a.sh" for external facts: child process returned non-zero exit status (8).
      

      Filing this as a bug ticket and resolving it so we can reference this fix.

        Attachments

          Activity

            People

            Assignee:
            ciprian.badescu Ciprian Badescu
            Reporter:
            garrett.guillotte Garrett Guillotte
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support