[FACT-2851] Failure when structured custom fact has a wrong layout - Puppet Jira Server

XML

Word

Printable

Acceptance Criteria:

Hide

For this particular case we should output an error stating that something is wrong with how the layout of the structured fact, or that we can not add a fact to a fact's value.

Show
For this particular case we should output an error stating that something is wrong with how the layout of the structured fact, or that we can not add a fact to a fact's value.
Team:
Night's Watch
Sub-team:
- ghost
Story Points:
2
Sprint:
ghost-11.11, ghost 25.11
Method Found:
Needs Assessment

Release Notes:
Enhancement
Release Notes Summary:
Added log message when custom fact names are incompatible and a fact hierarchy cannot be created.

When creating a structured custom fact with:

# frozen_string_literal: true

Facter.add(:'my_fact.f1') do

  setcode do

    'f1_value'

end

end

Facter.add(:'my_fact.f1.l1') do

  setcode do

    'f1_l1_value'

end

end

When requesting for my_fact, facter fails with:

NoMethodError: undefined method `bury' for "f1_value":String

  /Users/andrei.filipovici/projects/facter_fork/lib/facter/models/fact_collection.rb:33:in `bury'

This happens because my_fact.f1.l1 tries to add a fact to my_fact.f1's value.