Uploaded image for project: 'Facter'
  1. Facter
  2. FACT-2859

[regression] External facts are loaded when using puppet lookup for a different node

    XMLWordPrintable

    Details

    • Template:
    • Team:
      Night's Watch
    • Sub-team:
    • Story Points:
      2
    • Sprint:
      ghost 25.11, ghost-2.12, ghost-9.12
    • Method Found:
      Needs Assessment
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      An API method ( load_external) was missing on Facter 4 and added with this ticket.
    • QA Risk Assessment:
      Needs Assessment

      Description

      FACT-2666 added a Facter.load_external method which puppet checks to enable/disable external fact loading. The method was added to facter 3, but doesn't exist in facter 4, so puppet doesn't disable external fact loading.

      # rpm -qa | grep puppet
      puppet-agent-7.0.0-1.el8.x86_64
      # cat /opt/puppetlabs/facter/facts.d/slow.sh
      #!/bin/sh
       
      >&2 echo "this is slow"
      # chmod u+x /opt/puppetlabs/facter/facts.d/slow.sh
      # puppet lookup --node notme key
      Warning: Facter: Command /opt/puppetlabs/facter/facts.d/slow.sh completed with the following stderr message: this is slow
      Warning: Facter: Command /opt/puppetlabs/facter/facts.d/slow.sh completed with the following stderr message: this is slow
      

      This wasn't noticed in tests, because we don't verify partial doubles:
      https://github.com/puppetlabs/puppet/blob/29a737f765d94bfb30bdb3d89c55e54edfcc16b9/spec/integration/application/lookup_spec.rb#L101-L102

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              oana.tanasoiu Oana Tanasoiu
              Reporter:
              josh Josh Cooper
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support