[FACT-2872] Regressions: secondary interfaces are not anymore reported - Puppet Tickets

Release Notes:
Bug Fix
Release Notes Summary:

Hide
Networking.interfaces, now displays secondary interfaces (with or without label) and VLANs.
MAC address is correctly displayed for bonded interfaces.
If DHCP is not found command `dhcpcd -U <interface_name>` is used for an additional search.

Show
Networking.interfaces, now displays secondary interfaces (with or without label) and VLANs. MAC address is correctly displayed for bonded interfaces. If DHCP is not found command `dhcpcd -U <interface_name>` is used for an additional search.

Secondary IPs on interfaces are not anymore available as a fact:

 # ip a

1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000

    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00

    inet 127.0.0.1/8 scope host lo

       valid_lft forever preferred_lft forever

    inet6 ::1/128 scope host

       valid_lft forever preferred_lft forever

2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000

    link/ether 52:54:00:da:ff:c0 brd ff:ff:ff:ff:ff:ff

    inet 192.168.1.38/24 brd 192.168.1.255 scope global eth0

       valid_lft forever preferred_lft forever

    inet 192.168.1.42/24 brd 192.168.1.255 scope global secondary eth0:1

       valid_lft forever preferred_lft forever

    inet6 fe80::5054:ff:feda:ffc0/64 scope link

       valid_lft forever preferred_lft forever

# facter version

4.0.46

# facter networking

  domain => "example.ch",

  fqdn => "foo.example.ch",

  hostname => "foo",

  interfaces => {

    eth0 => {

      bindings => [

          address => "192.168.1.38",

          netmask => "255.255.255.0",

          network => "192.168.1.0"

},

          address => "192.168.1.42",

          netmask => "255.255.255.0",

          network => "192.168.1.0"

],

      bindings6 => [

          address => "fe80::5054:ff:feda:ffc0",

          netmask => "ffff:ffff:ffff:ffff::",

          network => "fe80::"

],

      ip => "192.168.1.38",

      ip6 => "fe80::5054:ff:feda:ffc0",

      mac => "52:54:00:da:ff:c0",

      mtu => 1500,

      netmask => "255.255.255.0",

      netmask6 => "ffff:ffff:ffff:ffff::",

      network => "192.168.1.0",

      network6 => "fe80::",

      scope6 => "link"

},

    lo => {

      bindings => [

          address => "127.0.0.1",

          netmask => "255.0.0.0",

          network => "127.0.0.0"

],

      bindings6 => [

          address => "::1",

          netmask => "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff",

          network => "::1"

],

      ip => "127.0.0.1",

      ip6 => "::1",

      mtu => 65536,

      netmask => "255.0.0.0",

      netmask6 => "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff",

      network => "127.0.0.0",

      network6 => "::1",

      scope6 => "host"

},

  ip => "192.168.1.38",

  ip6 => "fe80::5054:ff:feda:ffc0",

  mac => "52:54:00:da:ff:c0",

  mtu => 1500,

  netmask => "255.255.255.0",

  netmask6 => "ffff:ffff:ffff:ffff::",

  network => "192.168.1.0",

  network6 => "fe80::",

  primary => "eth0",

  scope6 => "link"

# puppet show facts | grep 192.168.1.42

vs.

# facter --version

3.14.14 (commit e36657bea27254f003c8fc71d8ef57454db643e2)

# facter networking

  domain => "example.ch",

  fqdn => "foo.glei.ch",

  hostname => "foo",

  interfaces => {

    eth0 => {

      bindings => [

          address => "192.168.1.38",

          netmask => "255.255.255.0",

          network => "192.168.1.0"

],

      bindings6 => [

          address => "fe80::5054:ff:feda:ffc0",

          netmask => "ffff:ffff:ffff:ffff::",

          network => "fe80::"

],

      ip => "192.168.1.38",

      ip6 => "fe80::5054:ff:feda:ffc0",

      mac => "52:54:00:da:ff:c0",

      mtu => 1500,

      netmask => "255.255.255.0",

      netmask6 => "ffff:ffff:ffff:ffff::",

      network => "192.168.1.0",

      network6 => "fe80::",

      scope6 => "link"

},

    eth0:1 => {

      bindings => [

          address => "192.168.1.42",

          netmask => "255.255.255.0",

          network => "192.168.1.0"

],

      ip => "192.168.1.42",

      netmask => "255.255.255.0",

      network => "192.168.1.0"

},

    lo => {

      bindings => [

          address => "127.0.0.1",

          netmask => "255.0.0.0",

          network => "127.0.0.0"

],

      bindings6 => [

          address => "::1",

          netmask => "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff",

          network => "::1"

],

      ip => "127.0.0.1",

      ip6 => "::1",

      mtu => 65536,

      netmask => "255.0.0.0",

      netmask6 => "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff",

      network => "127.0.0.0",

      network6 => "::1",

      scope6 => "host"

},

  ip => "192.168.1.38",

  ip6 => "fe80::5054:ff:feda:ffc0",

  mac => "52:54:00:da:ff:c0",

  mtu => 1500,

  netmask => "255.255.255.0",

  netmask6 => "ffff:ffff:ffff:ffff::",

  network => "192.168.1.0",

  network6 => "fe80::",

  primary => "eth0",

  scope6 => "link"

causes

FACT-2871 Regression: interfaces without an ipaddress assigned are not anymore reported

is duplicated by

FACT-2886 networking.interfaces fact not appearing

Regressions: secondary interfaces are not anymore reported