Uploaded image for project: 'Facter'
  1. Facter
  2. FACT-2962

Facter 4 should accept the same time units in ttls (config file field) as Facter 3

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: FACT 4.0.52
    • Component/s: None
    • Labels:
    • Template:
    • Team:
      Ghost
    • Story Points:
      2
    • Sprint:
      ghost-10.03.2021
    • Method Found:
      Needs Assessment
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      Description of the problem: Facter 4 doesn't support all time units that Facter 3 previously did.
      Description of the fix: The following time units for ttls config field were added: "ns", "nanos", "nanoseconds", "us", "micros", "microseconds", "ms", "milis", "milliseconds", "s", "m", "h", "d". Also all the longer variants are accepted even without a trailing "s" (ex: mili, nano, etc are accepted).
      Show
      Description of the problem: Facter 4 doesn't support all time units that Facter 3 previously did. Description of the fix: The following time units for ttls config field were added: "ns", "nanos", "nanoseconds", "us", "micros", "microseconds", "ms", "milis", "milliseconds", "s", "m", "h", "d". Also all the longer variants are accepted even without a trailing "s" (ex: mili, nano, etc are accepted).
    • QA Risk Assessment:
      Needs Assessment

      Description

      Facter 4 supports the following time units for ttls: second(s), minute(s), hour(s), day(s).

      In order to be fully compatible with facter 3, Facter 4 should support similar time units:
      https://github.com/puppetlabs/cpp-hocon/blob/6ba46c077facd9339115f075d1521d20584826fd/lib/src/config.cc#L443-L461
      and
      https://github.com/puppetlabs/cpp-hocon/blob/6ba46c077facd9339115f075d1521d20584826fd/lib/src/config.cc#L473-L475

        Attachments

          Activity

            People

            Assignee:
            oana.tanasoiu Oana Tanasoiu
            Reporter:
            oana.tanasoiu Oana Tanasoiu
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support