Uploaded image for project: 'Facter'
  1. Facter
  2. FACT-297

PR (625): (fact-81) Use Emit.dump rather than to_plist - kylog

    Details

    • Type: Task
    • Status: Closed
    • Priority: Normal
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Community
    • Labels:
    • Template:

      Description

      (fact-81) Use Emit.dump rather than to_plist

      Pull Request Description


      See https://github.com/puppetlabs/facter/pull/499 and the linked
      redmine tickets for backstory. The basic issue here is that
      CFPropertyList monkey-patches some core ruby classes with a
      to_plist method, which defaults to returning binary data. This
      code was originally written to the vendored CFPropertyList
      previously included in facter (but unvendored in fact-94),
      which provided a different to_plist implementation returning
      text data.

      This commit avoids the conflicting to_plist implementations by
      calling its own dump method, thus no change in behavior.


      (webhooks-id: 5154191d35bec00561b4abf1d9aa2c6b)

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              gepetto-bot gepetto-bot
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Zendesk Support