Details
-
Bug
-
Status: Resolved
-
Normal
-
Resolution: Fixed
-
None
-
None
-
Night's Watch
-
2
-
NW - 2021-03-31, NW - 2021-04-14
-
Manual Test
-
Bug Fix
-
Certain mountpoints.options facts on macOSX were found to be differently represented in Facter 4 than Facter 3. This fix aligns them accordingly.
-
Needs Assessment
Description
Running puppet facts diff on macOS gives the following output:
{
|
"mountpoints./Volumes/puppet-agent-6.21.1.28.g8d35b8853-1.osx10.14.options.0": {
|
"new_value": "read-only",
|
"old_value": "readonly"
|
}
|
There is an extra hyphen for readonly in the mountpoint options in Facter 4. This is probably the culprit in 3: https://github.com/puppetlabs/facter/blob/3.x/lib/src/facts/bsd/filesystem_resolver.cc#L55.
On the other hand, Facter 4, uses sys-filesystem: https://github.com/djberg96/sys-filesystem/blob/9880f127465e680534263ec0de078179d73ef18b/lib/sys/unix/sys/filesystem.rb#L16