Uploaded image for project: 'Facter'
  1. Facter
  2. FACT-3073

Inconsistencies to set Facter::Core::Execution.execute timeout

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • None
    • FACT 4.2.5
    • Facter 4
    • Night's Watch
    • 1
    • NW - 2021-09-22
    • Needs Assessment
    • Bug Fix
    • Hide
      Fix the mismatch of `Facter::Core::Execution.execute` arguments between Facter 3 and Facter 4. The `.execute` method now accepts a `timeout` option like Facter 3 does, and warns when unsupported options are passed in. (Fix contributed by community members https://github.com/smortex and https://github.com/johanfleury)
      Show
      Fix the mismatch of `Facter::Core::Execution.execute` arguments between Facter 3 and Facter 4. The `.execute` method now accepts a `timeout` option like Facter 3 does, and warns when unsupported options are passed in. (Fix contributed by community members https://github.com/smortex and https://github.com/johanfleury)
    • Needs Assessment

    Description

      The Facter::Core::Execution.execute method accept an option hash to control execution.

      The documentation tell to use "time_limit" to set a max duration for the command to complete, but the code actually use "limit" to set this.

      I happen that the previous version of Facter used "timeout" for this duration.

      Attachments

        Activity

          People

            gabriel.nagy Gabriel Nagy
            smortex Romain Tartière
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Zendesk Support