Uploaded image for project: 'Facter'
  1. Facter
  2. FACT-324

PR (632): Bugfix/facter 2/fact 150 process waitall - adrienthebo

    Details

    • Type: Task
    • Status: Closed
    • Priority: Normal
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Community
    • Labels:
    • Template:

      Description

      Bugfix/facter 2/fact 150 process waitall

      Pull Request Description


      This pull request implements an abstraction layer for how commands are run on different versions of Ruby. It also paves the way for extracting Windows specific behavior into a subclass so that we don't have to intermingle POSIX and Windows behaviors in the same method, although we're kicking that can down the road a bit.

      More importantly this adds a partial resolution for FACT-150. We can now wait on a single PID when waiting for a process to exit instead of waiting on all PIDs but this can only be done on Ruby 1.9+.


      (webhooks-id: 8760942f60e531de7cd98e286d3105f2)

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              gepetto-bot gepetto-bot
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Zendesk Support