Uploaded image for project: 'Facter'
  1. Facter
  2. FACT-610

Change windows facter to return same hardware model as linux

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • FACT 2.1.0
    • FACT 3.0.0
    • None

    • Windows 64 bit hardware/VM

    • 2
    • Client 2015-04-29
    • Bug Fix
    • Hide
      On Windows, the value of the hardware fact (os.hardware) has changed from "x64" to "x86_64" for 64-bit Windows editions. This change was made so that Windows is consistent with other operating systems. The architecture fact is still "x64" as it represents the platform-specific name for the system architecture.
      Show
      On Windows, the value of the hardware fact (os.hardware) has changed from "x64" to "x86_64" for 64-bit Windows editions. This change was made so that Windows is consistent with other operating systems. The architecture fact is still "x64" as it represents the platform-specific name for the system architecture.

    Description

      facter's fact hardwaremodel on windows is returned as x64 for 64 bit hardware systems. This is not the same as what is returned by Linux systems. On linux hardwaremodel is x86_64.

      This causes a separate hardwaremodel group to be created when they are actually the same thing.

      I am attaching the patched file hardwaremodel.rb but I'm not familiar with the rest of the process to progress it into the product. It is a one line change. Path on a windows system is
      c:\Program Files (x86)\Puppet Labs\Puppet\facter\lib\facter

      Update: Comments support updating hardwaremodel to match across platforms (i.e. x86_64 and ix86), leaving architecture unchanged. That's what the PR does.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. FACT-955 Reports incorrect hardware/architecture facts for 32-bit process on 64-bit OS, and 32-bit OS on 64-bit hardware

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. FACT-958 Acceptance test covering facts based on platform

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed
          links to

          Web Link Merge #925

          Web Link PR #925

          Web Link Test Rail test case ID 64677

          Activity

            People

              Unassigned Unassigned
              grants Grant Street
              Kurt Wall Kurt Wall
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support