Uploaded image for project: 'Facter'
  1. Facter
  2. FACT-824

Reduce calls to 'ip link show' in Facter::Util::IP

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: FACT 1.7.4
    • Fix Version/s: FACT 2.4.3
    • Component/s: Community
    • Labels:
      None
    • Environment:

      Linux (Debian 7.8 Wheezy)

    • Template:
    • Story Points:
      1
    • Sprint:
      Client 2015-04-15

      Description

      Facter::Util:IP.get_interface_value calls get_bonding_interface for every possible value. However the result is only used for macaddress lookups.

      Since get_bonding_interface makes a call to `ip link show` this can become a performance issue if many interfaces are present.

      Already affects facter 1.5.3.

      risk: low (no need for separate test/validation, covered by schema test)
      probability: medium (any IP/mac fact)
      severity: low (performance only)
      test layer: unit

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                holstvoogd Arthur Holstvoogd
                QA Contact:
                Eric Thompson
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support