Uploaded image for project: 'Puppet Forge'
  1. Puppet Forge
  2. FORGE-471

API pagination links mangle value of "exclude_fields" query param

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Component/s: None
    • Labels:
      None
    • Template:
    • Acceptance Criteria:
      • Value of exclude_fields query param should be safely preserved in the next/prev pagination links of an API response.
    • Team:
      Puppet Developer Experience
    • Method Found:
      Customer Feedback
    • Release Notes:
      Not Needed
    • QA Risk Assessment:
      Needs Assessment

      Description

      From Josh Cooper:

      If I update PMT to exclude those fields as a comma separated list, it works for the first request (exclude_fields=readme,changelog,license)

      But the forge's pagination.next field in the response expands the multivalued parameter to "exclude_fields=readme&exclude_fields=changelog&exclude_fields=license"

      When the PMT makes the next request for the 2nd, etc page, the forge only honors the first parameter, so I still get changelog, etc

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              nik.anderson Nik Anderson
              Reporter:
              jesse Jesse Scott
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support