Uploaded image for project: 'Hiera'
  1. Hiera
  2. HI-65

PR (162): ignore empty yaml files - leinaddm

    Details

    • Type: Task
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: HI 2.0.0
    • Component/s: Community
    • Labels:
    • Template:
    • Story Points:
      1
    • Sprint:
      Week 2013-12-04 to 2013-12-11

      Description

      ignore empty yaml files

      Pull Request Description


      YAML.load returns nil for an empty file.
      'next if data.empty?' would raise an exception if reached.


      (webhooks-id: 707b3d754cd22c1babaf9a7b8606c473)

        Issue Links

          Activity

          Hide
          gepetto-bot gepetto-bot added a comment -

          puppetcla commented:

          CLA signed by all contributors.

          Show
          gepetto-bot gepetto-bot added a comment - puppetcla commented: CLA signed by all contributors.
          Hide
          gepetto-bot gepetto-bot added a comment -

          Pull request ignore empty yaml files has been closed.

          Show
          gepetto-bot gepetto-bot added a comment - Pull request ignore empty yaml files has been closed.
          Hide
          gepetto-bot gepetto-bot added a comment -

          adrienthebo commented:

          Merged into master; this should be in the next release of Hiera. As a note I reworded your commit to add the related issue to the message and added spec tests to ensure that we don't regress on this. Thanks for the contribution!

          Show
          gepetto-bot gepetto-bot added a comment - adrienthebo commented: Merged into master; this should be in the next release of Hiera. As a note I reworded your commit to add the related issue to the message and added spec tests to ensure that we don't regress on this. Thanks for the contribution!
          Hide
          kurt.wall Kurt Wall added a comment -

          Verified in pl-hiera-af58ecb698b57e2f536803d545b3d2a18e2b107c.

          Empty YAML files and those with just a header ("---\n"), get ignored.

          Show
          kurt.wall Kurt Wall added a comment - Verified in pl-hiera-af58ecb698b57e2f536803d545b3d2a18e2b107c. Empty YAML files and those with just a header ("---\n"), get ignored.
          Hide
          rnelson0@gmail.com Rob Nelson added a comment -

          Correcting resolved tickets to closed as needed (triage-a-thon).

          Show
          rnelson0@gmail.com Rob Nelson added a comment - Correcting resolved tickets to closed as needed (triage-a-thon).
          Hide
          rnelson0@gmail.com Rob Nelson added a comment -

          Unclosing 1.4.0 tickets.

          Show
          rnelson0@gmail.com Rob Nelson added a comment - Unclosing 1.4.0 tickets.

            People

            • Assignee:
              Unassigned
              Reporter:
              gepetto-bot gepetto-bot
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile