Uploaded image for project: 'Modules'
  1. Modules
  2. MODULES-10713

Upgrading to dev builds is not idempotent on Solaris 11

    XMLWordPrintable

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: puppet_agent
    • Labels:
      None
    • Template:
    • Team:
      Night's Watch
    • Story Points:
      2
    • Sprint:
      NW - 2020-06-24
    • Release Notes:
      Not Needed
    • QA Risk Assessment:
      Needs Assessment

      Description

      https://github.com/puppetlabs/puppetlabs-puppet_agent/blob/master/manifests/init.pp#L172 munges package versions on Solaris 11 by stripping all letters (i.e.: 5.5.20.102.g9e5216a6 turns to 5.5.20.102.952166).

      This in turn causes the version check here to fail: https://github.com/puppetlabs/puppetlabs-puppet_agent/blob/d26fab5cdcba8f96478d07012cbdcfe146161f0f/lib/puppet/provider/puppet_agent_end_run/puppet_agent_end_run.rb#L33

      Gem::Version.new(...).release.version would strip the git SHA from the version, but in our case letters were already stripped, causing 5.5.20.102.952166 to be treated as the desired version (instead of 5.5.20.102, which would correspond to the aio_agent_build fact)

      As far as I can tell, this peculiarity is limited to Solaris 11.

        Attachments

          Activity

            People

            Assignee:
            gabriel.nagy Gabriel Nagy
            Reporter:
            gabriel.nagy Gabriel Nagy
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support