Uploaded image for project: 'Modules'
  1. Modules
  2. MODULES-11262

puppet_agent: acceptance test fails if latest puppet-agent fails to ship

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • None
    • None
    • puppet_agent
    • None
    • Phoenix
    • Phoenix 2022-03-16
    • Needs Assessment
    • Needs Assessment

    Description

      The upgrade 6 to 7 acceptance test sometimes fails due to a mismatch between the expected and actual versions.

      The test executes the following to determine the "expected" version of puppet-agent:

      $ curl http://builds.delivery.puppetlabs.net/passing-agent-SHAs/puppet-agent-main-version
      7.14.0.30.g20a88eef0
      

      It then uses puppet to upgrade the puppet-agent package from puppet6 to puppet7. For example, here yum detects what the latest available version is:

       Debug: Executing: '/usr/bin/rpm --version'
            Debug: Executing '/usr/bin/rpm -qa --nosignature --nodigest --qf '%{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\n' | sort'
            Debug: Executing: '/usr/bin/yum check-update'
            Debug: /Stage[main]/Puppet_agent::Install/Package[puppet-agent]/ensure: puppet-agent "6.26.0.15.g1cfea1b33-1.el7" is installed, latest is "0:7.14.0.17.g886bb7cc0-1.el7"
      

      After the upgrade, the test uses the aio_agent_version fact to determine what was actually installed:

       newborn-tongue.delivery.puppetlabs.net (newborn-tongue.delivery.puppetlabs.net) 17:28:46$ facter aio_agent_version
            7.14.0.17
      

      And since they don't match, the test fails:

          newborn-tongue.delivery.puppetlabs.net (newborn-tongue.delivery.puppetlabs.net) executed in 0.40 seconds
      Minitest::Assertion: Expected 'newborn-tongue.delivery.puppetlabs.net (el-7-x86_64)' agent to be upgraded to puppet-agent 7.14.0.23, but detected '7.14.0.17' instead.
      Expected: "7.14.0.23"
        Actual: "7.14.0.17"
      

      This problem occurs whenever puppet-agent passes CI and the "expected" file puppet-agent-main-version is updated, but the nightly ship job fails.

      It can also happen if a new nightly version of puppet-agent is shipped between the time the module pipeline starts and when the test runs.

      Attachments

        Activity

          People

            christopher.thorn Christopher Thorn
            josh Josh Cooper
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Zendesk Support