Uploaded image for project: 'Modules'
  1. Modules
  2. MODULES-3430

Chocolatey source should not default location to resource title/name

    XMLWordPrintable

Details

    • Task
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • None
    • None
    • chocolatey
    • Hide

      Location should be explicitly required.

      • Attempt to set a source without location - should fail
      • Attempt to set a source with location - should work
      • Disable a source without specifying location - should work
      Show
      Location should be explicitly required. Attempt to set a source without location - should fail Attempt to set a source with location - should work Disable a source without specifying location - should work
    • Modules
    • 2
    • Windows 2016-08-24, Windows 2016-09-07, Modules 2016-09-21

    Description

      Not required before next unsupported release.
      Ideally these tests are automated

      Originally I wanted to specify a source name and location as a one shot deal:

      chocolateysource { 'c:\\packages': } 
      

      However this could cause confusion - A user could specify

      chocolateysource {'chocolatey':}
      

      Would set the default repository source id to chocolatey and source location to chocolatey, instead of the default https://chocolatey.org/api/v2. This is just an example as most would disable that source, but if it happens, it could be quite alarming for users. We've looked over other repo configuration providers, yumrepo and it requires explicitly setting the baseurl. So we've decided we should follow the same approach and remove the default setting.

      It's possible that if someone set source disabled and then removed the disabled, they could accidentally trigger this behavior.

      Attachments

        Issue Links

          Activity

            People

              james.pogran James Pogran
              rob Rob Reynolds
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support