Uploaded image for project: 'Modules'
  1. Modules
  2. MODULES-3434

Agent Upgrade - Do not wait indefinitely on AGENT_PID

    XMLWordPrintable

    Details

    • Template:
    • Story Points:
      2
    • Sprint:
      Windows 2016-08-10

      Description

      The current install_puppet.bat.erb waits 5 seconds, before each attempt to see if the PID of the calling process has exited.

      https://github.com/puppetlabs/puppetlabs-puppet_agent/blob/master/templates/install_puppet.bat.erb#L12-L16 loops infinitely, and this should have a timeout.

      A couple of options for addressing this:

      • Stop waiting after X seconds, don't proceed with installer (and log to event log?)
      • Forcefully kill the agent PID using taskkill - now that 3.7 is supported, this might be necessary under some circumstances. PUP-2987 addressed some service hang / deadlock issues in Puppet 3.7, but I don't believe they had yet made it into MCO (this might need to be addressed in a different independent ticket - to expand the scope of agent upgrade to forcefully terminate services that don't shut down gracefully)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              ethan Ethan Brown
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support