Uploaded image for project: 'Modules'
  1. Modules
  2. MODULES-3472

inifile: 1.5.0 breaks backwards compatibility of create_ini_settings

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: inifile
    • Labels:
      None
    • Template:
    • Acceptance Criteria:
      Hide

      Writing acceptance tests using the failure condition - referencing the resource with brackets.

      Show
      Writing acceptance tests using the failure condition - referencing the resource with brackets.
    • Story Points:
      2
    • Sprint:
      MODS 2016-07-27

      Description

      Hello,

      So I stumbled upon something interesting today. While I was writing a module I noticed that I was getting difference resource names while using the inifile function

      create_ini_settings()

      between versions 1.4.3 and 1.5.0.

      If for example I had 1.4.3 of the inifile module in my environment and a bunch of modules that was using inifile. In those modules I perhaps am using the create_ini_settings function and also have a few other resources and then used require/before on some resources to the Ini_setting resource I knew would be created.

      So in 1.4.3 the default resource name for ini_settings would be called

      res["[#{section}] #{setting}"] = {

      while for 1.5.0 it would be called...

      res["#{path} #{section} #{setting}"] = { 

      So my argument here is that this release is not following the semantic versioning guidelines since it will break any modules using the create_ini_settings() function and resource chaining because the resource naming has changed.

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  helen Helen Campbell
                  Reporter:
                  Propyless Takeshi Larsson
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: