Uploaded image for project: 'Forge Modules'
  1. Forge Modules
  2. MODULES-3568

stdlib: copy dig to dig44; deprecate original version

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Template:
    • Acceptance Criteria:
      • both dig and dig44 conform to the old API on puppet prior to puppet 4.5.0
      • using stdlib's dig prints a warning
      • catalog and full-system tests pass green
      • README is updated
    • Story Points:
      1

      Description

      puppet 4.5.0 has introduced a internal version of dig, that is not compatible to stdlib's version. To mitigate this, we need to

      • rename the dig function to dig44 to keep the old API available
      • create a new dig function that warns the user that they should be either using dig44 or switch to puppet 4.5.0's dig function.

        Attachments

          Issue Links

            Activity

            Hide
            ntpttr Nate Potter added a comment -

            I submitted a pull request to handle this here https://github.com/puppetlabs/puppetlabs-stdlib/pull/618 , but it looks like the Ruby 1.9.6 job is failing because of an issue like this one https://github.com/travis-ci/travis-ci/issues/5145

            Show
            ntpttr Nate Potter added a comment - I submitted a pull request to handle this here https://github.com/puppetlabs/puppetlabs-stdlib/pull/618 , but it looks like the Ruby 1.9.6 job is failing because of an issue like this one https://github.com/travis-ci/travis-ci/issues/5145
            Hide
            david.schmitt David Schmitt added a comment -

            The failing travis check is a known issue with newer versions of mime-types-data requiring ruby >=2 and bundler being obnoxious about it.

            Show
            david.schmitt David Schmitt added a comment - The failing travis check is a known issue with newer versions of mime-types-data requiring ruby >=2 and bundler being obnoxious about it.
            Hide
            david.schmitt David Schmitt added a comment -

            merged Nate's PR

            Show
            david.schmitt David Schmitt added a comment - merged Nate's PR

              People

              • Assignee:
                ntpttr Nate Potter
                Reporter:
                david.schmitt David Schmitt
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support