Uploaded image for project: 'Modules'
  1. Modules
  2. MODULES-3636

Agent Upgrade - PID check currently depends on English string, fails on non-English Windows

    XMLWordPrintable

    Details

    • Template:
    • Acceptance Criteria:
      Hide

      Agent upgrades work correctly on German or French Windows (really, anything other than English)

      Show
      Agent upgrades work correctly on German or French Windows (really, anything other than English)
    • Story Points:
      2
    • Sprint:
      Windows 2016-07-27, Windows 2016-08-10

      Description

      The agent upgrade wait script on Windows runs tasklist then searches for English string No tasks are running at https://github.com/puppetlabs/puppetlabs-puppet_agent/blob/master/templates/install_puppet.bat.erb#L18. This string is never found on non-English Windows, which will block the upgrade indefinitely (due to MODULES-3434), and may cause additional upgrades to be queued up on each subsequent agent run.

      The solution here is to use qprocess which returns an exit code based on process id.

      QProcess doesn't exist on Nano, so the solution is wmic instead.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              ethan Ethan Brown
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support