Uploaded image for project: 'Modules'
  1. Modules
  2. MODULES-4280

svn provider no longer working

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: vcsrepo
    • Labels:
      None
    • Environment:

      puppetlabs-vcsrepo (v1.5.0)

    • Template:
    • Acceptance Criteria:
      Hide

      svn provider not failing.

      Show
      svn provider not failing.
    • QA Risk Assessment:
      Needs Assessment

      Description

      Since commit d26905fde50c4b8ce47dc0da7232028dc914a327 svn provider is no longer working.

      Problem is:
      Error: /Vcsrepo[/usr/local/custom]: Could not evaluate: undefined method `sourceurl' for #<Puppet::Type::Vcsrepo::ProviderSvn:0x000000030478f8>

      The error is:
      https://github.com/puppetlabs/puppetlabs-vcsrepo/commit/d26905fde50c4b8ce47dc0da7232028dc914a327#diff-574463866055cc3f49ee013638f6652aL80

      the method has been renamed in source, while still referred as sourceurl.

      Just changing sourceurl to source seems to do the job, but i have not deeply tested.

      — /var/lib/puppet/lib/puppet/provider/vcsrepo/svn.rb 2017-01-12 20:06:07.494165296 +0100
      +++ /tmp/puppet-file20170112-91179-5nx63h 2017-01-12 23:37:04.293578949 +0100
      @@ -59,7 +59,7 @@

      def latest?
      at_path do

      • (self.revision >= self.latest) and (@resource.value(:source) == self.sourceurl)
        + (self.revision >= self.latest) and (@resource.value(:source) == self.source)
        end
        end

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              Rocco83 Daniele Palumbo
              Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support