Details
-
Bug
-
Status: Resolved
-
Blocker
-
Resolution: Fixed
-
None
-
None
-
None
-
None
-
- unit tests pass
- acceptance tests all pass
-
Modules
-
Needs Assessment
-
Needs Assessment
Description
With puppet agent 5.5.0 release unit tests in Travis fail. This is due to a feature that has been implemented https://puppet.com/docs/puppet/5.5/release_notes.html#new-features.
The failures that have been seen are unit tests and one acceptance test.
puppet 5.5.0
Negative unit tests are failing against each function.
3152 examples, 22 failures, 76 pending
|
Failed examples:
|
rspec ./spec/functions/empty_spec.rb:5 # empty should run empty() and raise an Puppet::ParseError
|
rspec ./spec/functions/flatten_spec.rb:5 # flatten should run flatten() and raise an Puppet::ParseError
|
rspec ./spec/functions/flatten_spec.rb:6 # flatten should run flatten([], []) and raise an Puppet::ParseError
|
rspec ./spec/functions/flatten_spec.rb:7 # flatten should run flatten(1) and raise an Puppet::ParseError
|
rspec ./spec/functions/flatten_spec.rb:8 # flatten should run flatten("one") and raise an Puppet::ParseError
|
rspec ./spec/functions/join_spec.rb:5 # join should run join() and raise an Puppet::ParseError with the message matching /wrong number of arguments/i
|
rspec ./spec/functions/join_spec.rb:10 # join should run join("one") and raise an Puppet::ParseError with the message matching /Requires array to work with/
|
rspec ./spec/functions/join_spec.rb:11 # join should run join([], 2) and raise an Puppet::ParseError with the message matching /Requires string to work with/
|
rspec ./spec/functions/keys_spec.rb:5 # keys should run keys() and raise an Puppet::ParseError with the message matching /wrong number of arguments/i
|
rspec ./spec/functions/keys_spec.rb:10 # keys should run keys("") and raise an Puppet::ParseError with the message matching /Requires hash to work with/
|
rspec ./spec/functions/keys_spec.rb:11 # keys should run keys(1) and raise an Puppet::ParseError with the message matching /Requires hash to work with/
|
rspec ./spec/functions/keys_spec.rb:12 # keys should run keys([]) and raise an Puppet::ParseError with the message matching /Requires hash to work with/
|
rspec ./spec/functions/keys_spec.rb:15 # keys returns the array of keys
|
rspec ./spec/functions/keys_spec.rb:20 # keys runs with UTF8 and double byte characters
|
rspec ./spec/functions/length_spec.rb:7 # length should run length(1) and raise an ArgumentError with the message matching /expects a value of type String, Array, or Hash, got Integer/
|
rspec ./spec/functions/length_spec.rb:8 # length should run length(true) and raise an ArgumentError with the message matching /expects a value of type String, Array, or Hash, got Boolean/
|
rspec ./spec/functions/values_spec.rb:5 # values should run values() and raise an Puppet::ParseError with the message matching /wrong number of arguments/i
|
rspec ./spec/functions/values_spec.rb:10 # values should run values("") and raise an Puppet::ParseError with the message matching /Requires hash to work with/
|
rspec ./spec/functions/values_spec.rb:11 # values should run values(1) and raise an Puppet::ParseError with the message matching /Requires hash to work with/
|
rspec ./spec/functions/values_spec.rb:12 # values should run values([]) and raise an Puppet::ParseError with the message matching /Requires hash to work with/
|
rspec ./spec/functions/values_spec.rb:15 # values returns the array of values
|
rspec ./spec/functions/values_spec.rb:20 # values runs with UTF8 and double byte characters
|
Acceptance tests one is failing:
Failures:
|
|
|
1) values function failure handles non-hash arguments
|
Failure/Error: expect(apply_manifest(pp2, :expect_failures => true).stderr).to match(%r{Requires hash})
|
expected "\e[1;31mError: Evaluation Error: Error while evaluating a Function Call, 'values' parameter 'hsh' ex...ot String (file: /tmp/apply_manifest.pp.YiVzIR, line: 2, column: 17) on node ubuntu-1404-x64\e[0m\n" to match /Requires hash/
|
Diff:
|
@@ -1,2 +1,2 @@
|
-/Requires hash/
|
+Error: Evaluation Error: Error while evaluating a Function Call, 'values' parameter 'hsh' expects a Hash value, got String (file: /tmp/apply_manifest.pp.YiVzIR, line: 2, column: 17) on node ubuntu-1404-x64
|
|
|
|
|
# ./spec/acceptance/values_spec.rb:26:in `block (3 levels) in <top (required)>'
|
|
|
Finished in 8 minutes 36 seconds (files took 1 minute 13.8 seconds to load)
|
492 examples, 1 failure, 195 pending
|