Uploaded image for project: 'Modules'
  1. Modules
  2. MODULES-7034

dsc - Process kill test is unreliable

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Won't Do
    • None
    • None
    • dsc, windows
    • Hide

      The test and possible the powershell_manager itself, should be refactored so that the second call to Process.kill is not done. We want to verify that the powershell_manager has called kill without having to duplicate that effort in an unreliable way.

      Review the fix at powershell PR: https://github.com/puppetlabs/puppetlabs-powershell/pull/223

      Show
      The test and possible the powershell_manager itself, should be refactored so that the second call to Process.kill is not done. We want to verify that the powershell_manager has called kill without having to duplicate that effort in an unreliable way. Review the fix at powershell PR:  https://github.com/puppetlabs/puppetlabs-powershell/pull/223
    • Windows
    • Needs Assessment

    Description

      The powershell_manager_spec.rb test at line 61 ('should fail if the manger is created with a short timeout') is unreliable.

      After the powershell_manager has already called Process.kill, the test then attempts to do so a second to verify that it results in an error. The error is our indication that the first call inside the powershell_manager was successful and the test should pass. Unfortunately the result of this second call to Process.kill is unreliable. You can get many failures of this test in a row, and then suddenly it passes.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              william.hurt William Hurt
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support