Uploaded image for project: 'Modules'
  1. Modules
  2. MODULES-7425

scheduled_task : Refactor extraneous methods from taskscheduler2.rb

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Normal
    • Resolution: Done
    • Affects Version/s: scheduled_task 0.3
    • Fix Version/s: scheduled_task 0.4
    • Component/s: scheduled_task
    • Labels:
      None
    • Template:
    • Acceptance Criteria:
      • Above methods are removed from TaskScheduler2 class
      • Adapter classes access methods on the @definition object directly where it makes sense
      • Existing tests are sufficient
    • Team:
      Windows
    • Story Points:
      1
    • Sprint:
      Windows 2018-08-08
    • QA Risk Assessment:
      Needs Assessment

      Description

      There are a number of methods that don't provide any utility in taskscheduler2.rb

       

      These are methods like:

      • def self.principal(definition)
      • def self.compatibility(definition)
      • def self.set_compatibility(definition, value)
      • def self.action_count(definition)
      • def self.create_action(definition, action_type)
      • def self.trigger_count(definition)

       

      Given these methods all take the definition object, and provide little more than a light wrapper around it, they aren't particularly useful and additional layering to the class structure that is not necessary.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              ethan Ethan Brown
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support