Details
-
Bug
-
Status: Resolved
-
Critical
-
Resolution: Fixed
-
None
-
None
-
-
Windows
-
1
-
Windows 2018-07-25
-
Needs Assessment
-
Needs Assessment
Description
There are 3 parameters that are required for the dsc_lite module - module, resource_name and properties.
In their implementations they each currently call isrequired - https://github.com/puppetlabs/puppetlabs-dsc_lite/blob/75e0fce3d1194706ef4dab295af617e84bb58fcc/lib/puppet/type/dsc.rb#L43-L85
However, isrequired doesn't work ( see https://projects.puppetlabs.com/issues/4049 / https://tickets.puppetlabs.com/browse/PUP-1591 ), so this validation is never called. Instead a new top-level validator should be added like:
validate do |
raise ArgumentError, 'dsc: module is required' unless self[:module] |
raise ArgumentError, 'dsc: resource_name is required' unless self[:resource_name] |
raise ArgumentError, 'dsc: properties is required' unless self[:properties] |
end
|
Attachments
Issue Links
- relates to
-
MODULES-7528 SPIKE: Review Windows Modules for Required Parameters
-
- Ready for Engineering
-
-
MODULES-7178 dsc_lite: Modify the output report for dsc_lite resources to prefix type names with dsc_lite_#{resource_name}
-
- Resolved
-