[MODULES-7485] dsc_lite : 'isrequired' validation does not work - Puppet Jira Server

XML

Word

Printable

Acceptance Criteria:
Hide

New spec tests that demonstrate required fields

PE console delivers the error Failed to apply catalog: Validation of Dsc[sample_file2] failed: dsc: resource_name is required when the dsc resource_name instead of other errors
Show
New spec tests that demonstrate required fields PE console delivers the error Failed to apply catalog: Validation of Dsc [sample_file2] failed: dsc: resource_name is required when the dsc resource_name instead of other errors
Epic Link:
dsc_lite 0.6.0
Team:
Windows
Story Points:
1
Sprint:
Windows 2018-07-25
Method Found:
Needs Assessment

There are 3 parameters that are required for the dsc_lite module - module, resource_name and properties.

However, isrequired doesn't work ( see https://projects.puppetlabs.com/issues/4049 / https://tickets.puppetlabs.com/browse/PUP-1591 ), so this validation is never called. Instead a new top-level validator should be added like:

validate do

  raise ArgumentError, 'dsc: module is required' unless self[:module]

  raise ArgumentError, 'dsc: resource_name is required' unless self[:resource_name]

  raise ArgumentError, 'dsc: properties is required' unless self[:properties]

end

relates to

MODULES-7528 SPIKE: Review Windows Modules for Required Parameters

MODULES-7178 dsc_lite: Modify the output report for dsc_lite resources to prefix type names with dsc_lite_#{resource_name}