Uploaded image for project: 'Modules'
  1. Modules
  2. MODULES-7673

scheduled_task : Refactor Trigger canonicalize_and_validate_manifest code

    XMLWordPrintable

Details

    • Improvement
    • Status: Open
    • Normal
    • Resolution: Unresolved
    • None
    • None
    • scheduled_task, windows
    • None
      • Munging / validation occurs in the type and not the provider(s)
      • Existing tests should be audited and cleaned up
    • Windows
    • 1
    • Needs Assessment

    Description

      The code in the canonicalize_and_validate method of Trigger is doing two things... and is growing a bit lengthy.

      Think about ways to refactor this code to make it easier to understand.

      Furthermore, canonicalizing is effectively munging - munging should happen in the munge block for the type definition. Similarly, validation should happen then.

      As it stands, all of the code runs very late in the process - running inside the provider rather than the type. This should be rectified.

      Attachments

        Activity

          People

            Unassigned Unassigned
            ethan Ethan Brown
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Zendesk Support