Uploaded image for project: 'Modules'
  1. Modules
  2. MODULES-8446

puppet_agent: macOS upgrades fail silently when the path to the package file is invalid

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: puppet_agent
    • Labels:
      None
    • Template:
      MODULES Bug Template
    • Team:
      Platform OS
    • Sprint:
      Platform OS Kanban
    • Method Found:
      Manual Test
    • QA Risk Assessment:
      Needs Assessment

      Description

      It seems that when upgrading puppet-agent using the puppet_agent module on macOS, if the upgrade script is unable to find the downloaded package file, it fails silently, logging an error but not failing the puppet run.

      I found that this happened with puppetlabs-puppet_agent#master on macOS 10.12 while upgrading from 6.0.0 to 6.0.1 under FOSS. macOS upgrades are not supported for FOSS installations, but this should not fail silently.

      The upgrade script is here: https://github.com/puppetlabs/puppetlabs-puppet_agent/blob/master/templates/osx_install.sh.erb#L4

      The call to /usr/sbin/installer there may fail and log an error like this:

      installer: Error the package path specified was invalid: '/var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.NBcaLOUf/puppet-agent-*-installer.pkg'.
      /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/osx_install.log
      

        Attachments

          Activity

            People

            Assignee:
            casey.williams Casey Williams
            Reporter:
            casey.williams Casey Williams
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support