Details

    • Template:
    • Acceptance Criteria:
      • NSSM 2.2.5 is part of puppet-agent
      • There are no regressions in the management of pxp-agent (green runs through CI)
    • Team:
      Platform OS
    • Story Points:
      5
    • QA Risk Assessment:
      Needs Assessment

      Description

      For LTS agent 1.10.7 and beyond, to support DEP / ASLR, the MSVC++ compiler toolchain was introduced to be able to build NSSM (for use with pxp-agent) with the appropriate flags enabled.

      Because there were a number of fixes, including a critical fix for Windows 10, we initially tried to build off of the latest code at https://github.com/puppetlabs/nssm/commit/dee49fc1a0804f06687299b8e9612a3fce1c5e9a (+ some changes to support vcxproj files / latest MSVC++ 15 compiler). Unfortunately it was quickly discovered (see PA-1461) that there were some behavioral changes impacting tests.

      Given there has been 2 years of additional code changes from the last NSSM 2.2.4 release in 2014 (https://github.com/puppetlabs/nssm/compare/v2.24...master), it was decided to roll back to that version that we've been shipping, and to do only the minimum necessary to ensure it compiles under MSVC15.

      There are a number of fixes in the code since the 2.2.4 release, most notably a critical bug fix made recently for Windows 10. It is ultimately desirable to switch to the latest code, as long as we can prevent any regressions. To that end, the author of the NSSM project (Iain Patterson <me@iain.cx>) has been sent a minimal bug report disclosing the issue that was encountered. It may be necessary to perform further verification / submit upstream patches to NSSM from our fork.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                ethan Ethan Brown
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Zendesk Support