Uploaded image for project: 'Puppet Agent'
  1. Puppet Agent
  2. PA-1908

Remove redundant MCollective logrotate configuration from puppet-agent

    Details

    • Template:
    • Team:
      Bolt
    • Sprint:
      Bolt Kanban
    • CS Priority:
      Reviewed
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      MCollective now relies only on its internal log rotation rather than also using logrotate config. This prevents conflicting rotation and simplifies the config.
    • QA Risk Assessment:
      Needs Assessment

      Description

      Currently, we install a logrotate configuration file for MCollective as part of the puppet agent package:

      /etc/logrotate.d/mcollective

      However, MCollective also supports configuring the Ruby Logger to perform in-process rotation:

      https://github.com/puppetlabs/marionette-collective/blob/2.10.6/lib/mcollective/logger/file_logger.rb#L5-L16

      This Ruby rotation is enabled by default unless the user specifically configures it otherwise:

      https://github.com/puppetlabs/marionette-collective/blob/2.10.6/lib/mcollective/config.rb#L194-L195

      This means that the logrotate configuration is redundant since the mcollective daemon already rotates its own logs. The current configuration also has a flaw in that it restarts the mcollective daemon, which creates a thundering herd issue for larger installations: MCO-740

      Because of these issues, we should remove the logrotate configuration for MCollective from the puppet-agent package.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                chuck Charlie Sharpsteen
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support