Uploaded image for project: 'Puppet Agent'
  1. Puppet Agent
  2. PA-2112

Refactor Windows permission reset custom actions to a single vbscript custom action

    XMLWordPrintable

Details

      • 7 custom actions are refactored into 1 custom action
      • Relevant unused / unnecessary SetProperty calls are removed
    • Windows
    • 1
    • Windows 2018-07-18, Windows 2018-07-25, Windows 2018-08-01
    • Not Needed
    • Needs Assessment

    Description

      There are a 7 custom actions that were added as a part of PA-2019 in:

       

      While the custom actions make the commands more granular, they also necessitated corresponding property sets and care in properly ordering them. All of these actions are part of one logical unit and it would be better to treat them as such.

       

      Therefore, this code should be rewritten as a single custom action in VBScript, that behaves identical to previous code.

       

      Once this has been completed, it will be easier to perform checks to determine if the code should be run or not (since these operations are time consuming they should only be run once - filed separately as PA-2113

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. PUP-5491 The "client_data" Directory Permissions Incorrect After Installation

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. PUP-4759 windows inherited permissions problem on c:\programdata

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. PUP-5980 Fix "Puppet agent fails to write the graph if puppet agent has never run" issue for other faces

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. PUP-7793 Puppet agent replacing transactionstore.yaml on first run after boot

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. PA-2113 Only take ownership / reset Windows permissions once

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. PA-2075 Windows install corrupting permissions

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. PA-2019 Privilege escalation via %ProgramData%\PuppetLabs on Windows

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Activity

            People

              Unassigned Unassigned
              ethan Ethan Brown
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support