Details
-
Task
-
Status: Closed
-
Blocker
-
Resolution: Fixed
-
puppet-agent 1.10.14, puppet-agent 5.3.8, puppet-agent 5.5.3
-
- 7 custom actions are refactored into 1 custom action
- Relevant unused / unnecessary SetProperty calls are removed
-
Windows
-
1
-
Windows 2018-07-18, Windows 2018-07-25, Windows 2018-08-01
-
Not Needed
-
Needs Assessment
Description
There are a 7 custom actions that were added as a part of PA-2019 in:
- https://github.com/puppetlabs/puppet-agent/pull/1442 / https://github.com/puppetlabs/puppet-agent/commit/1dd5af46a864cd1f79883e0d9f1f36c2b83f8a97
While the custom actions make the commands more granular, they also necessitated corresponding property sets and care in properly ordering them. All of these actions are part of one logical unit and it would be better to treat them as such.
Therefore, this code should be rewritten as a single custom action in VBScript, that behaves identical to previous code.
Once this has been completed, it will be easier to perform checks to determine if the code should be run or not (since these operations are time consuming they should only be run once - filed separately as PA-2113
Attachments
Issue Links
- blocks
-
PUP-5491 The "client_data" Directory Permissions Incorrect After Installation
-
- Resolved
-
-
PUP-4759 windows inherited permissions problem on c:\programdata
-
- Closed
-
-
PUP-5980 Fix "Puppet agent fails to write the graph if puppet agent has never run" issue for other faces
-
- Closed
-
-
PUP-7793 Puppet agent replacing transactionstore.yaml on first run after boot
-
- Closed
-
-
PA-2113 Only take ownership / reset Windows permissions once
-
- Closed
-
- relates to
-
PA-2075 Windows install corrupting permissions
-
- Closed
-
-
PA-2019 Privilege escalation via %ProgramData%\PuppetLabs on Windows
-
- Closed
-