Uploaded image for project: 'Puppet Agent'
  1. Puppet Agent
  2. PA-2319

Remove curl binaries from Windows packages

    Details

    • Template:
    • Team:
      Platform OS
    • Sprint:
      Platform OS Kanban
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      Updates to the installation layout of puppet's core in puppet6 placed the curl binaries alongside puppet binaries (previously, they had been in a separate directory). This meant they were found before native curl in the PATH on more recent windows releases; We've removed the curl binaries on Windows (although the libraries haven't changed) to prevent this.
      Show
      Updates to the installation layout of puppet's core in puppet6 placed the curl binaries alongside puppet binaries (previously, they had been in a separate directory). This meant they were found before native curl in the PATH on more recent windows releases; We've removed the curl binaries on Windows (although the libraries haven't changed) to prevent this.
    • QA Risk Assessment:
      Needs Assessment

      Description

      https://github.com/puppetlabs/puppetlabs-chocolatey/blob/master/spec/support/utilities/helpers.rb#L29 fails with puppet6, since all binaries (including curl) arrive in the same location when using the updated paths in puppet-agent 6+. When puppet's bindir is included in the path, puppet's curl is used during this curl_on helper, bypassing the curl shipped in newer Windows installs.

      All curl binaries should be removed during the agent build's cleanup process to avoid this scenario. We should keep them for non-Windows platforms (support/community members have requested that we keep those).

        Attachments

          Activity

            People

            • Assignee:
              casey.williams Casey Williams
              Reporter:
              casey.williams Casey Williams
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Zendesk Support