[PA-2691] Custom MSI Action will not log STDERR to MSI log - Puppet Jira Server

XML

Word

Printable

Details

Type: Bug
Status: Resolved
Priority: Minor
Resolution: Fixed
Affects Version/s: None
Fix Version/s: puppet-agent 5.5.16, puppet-agent 6.0.10, puppet-agent 6.4.3, puppet-agent 6.7.0
Component/s: None
Labels:
- resolved-issue-added
Environment:

N/A Found while creating custom actions for PDK, using the same code.

Acceptance Criteria:
Hide

Manual test
Errors while running takeown etc., that are written to STDERR, should appear in the MSI log
Show
Manual test Errors while running takeown etc., that are written to STDERR, should appear in the MSI log
Team:
Night's Watch
Story Points:
1
Sprint:
PR - 2019-06-12, PR - 2019-06-25, PR - 2019-07-10
Method Found:
Needs Assessment

Release Notes:
Bug Fix
Release Notes Summary:
Correctly log STDERR in MSI installer log

QA Risk Assessment:
Needs Assessment

Description

In https://github.com/puppetlabs/puppet-agent/blob/e1a9b7d4b13ec4504d1fcbf70be1b42fbf2cff1a/resources/windows/wix/customactions.wxs.erb the ExecuteCommand function is supposed to redirect STDERR to STDOUT, which then logs to a file. However the order of the redirection is incorrect

Line https://github.com/puppetlabs/puppet-agent/blob/e1a9b7d4b13ec4504d1fcbf70be1b42fbf2cff1a/resources/windows/wix/customactions.wxs.erb#L340

Should be:

Dim exitCode : exitCode = wshShell.Run(Command & " > """ & tempFilePath & """ 2>&1 > ", 0, True)

The STDERR redirection must come after the file redirection.

Attachments

Activity

People

Assignee:: Gabriel Nagy

Reporter:: Glenn Sarti

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 2019/05/27 1:58 AM

Updated:: 2019/07/17 7:11 AM

Resolved:: 2019/07/05 1:38 AM

Zendesk Support