Uploaded image for project: 'Puppet Agent'
  1. Puppet Agent
  2. PA-2849

Net::HTTP can silently truncate downloads

    Details

    • Template:
    • Epic Link:
    • Team:
      Coremunity
    • Sprint:
      Platform Core KANBAN
    • Method Found:
      Needs Assessment
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Fixes a ruby bug that caused puppet to silently ignore truncated file downloads, such as when using a file resource whose source parameter contained a puppet, http, or https URL.
    • QA Risk Assessment:
      Needs Assessment

      Description

      Puppet Version:  4.10.9
      Puppet Server Version:  2.8.0
      OS Name/Version:  Windows 201x

      Describe your issue in as much detail as possible…

      The mtime checksum for a file resource, does not seem to work with Artifactory.  I don't know if this extends into oter http resources, but we are seeing this issue with Artifactory for sure.  

      I am aware of PUP-6114 for md5 checksum fixes, but this is for mtime.  I am not sure if there is already a ticket open for this or not, but I didnt see one, so here this is.

      We have 70 some servers that all have this issue.  Here is a file we are obtaining from artifactory, as you can see it has a last-modified time of:

       

      Last-Modified: Sat, 04 Aug 2018 08:19:42 GMT

       

       

      Here is a list of the server times of that file.  The size of the file is drastically different on every server as well.  Its a 1.4GB file and some servers only have a file size of 100KB.

       

      acdc04: 
      CreationTime : 8/6/2018 7:23:31 AM
      LastWriteTime : 8/6/2018 7:23:31 AM
      LastAccessTime : 8/6/2018 7:22:24 AM
      acdc22: 
      CreationTime : 8/6/2018 7:23:43 AM
      LastWriteTime : 8/6/2018 7:23:43 AM
      LastAccessTime : 8/6/2018 7:22:23 AM
      acdc10:
      CreationTime : 8/6/2018 7:24:51 AM
      LastWriteTime : 8/6/2018 7:24:51 AM
      LastAccessTime : 8/6/2018 7:19:49 AM
      acdc01:
      CreationTime : 8/6/2018 7:23:33 AM
      LastWriteTime : 8/6/2018 7:23:33 AM
      LastAccessTime : 8/6/2018 7:22:23 AM
      acdc15:
      CreationTime : 8/6/2018 7:24:25 AM
      LastWriteTime : 8/6/2018 7:24:24 AM
      LastAccessTime : 8/6/2018 7:19:47 AM
      acdc06:
      CreationTime : 8/6/2018 7:24:35 AM
      LastWriteTime : 8/6/2018 7:24:35 AM
      LastAccessTime : 8/6/2018 7:20:10 AM
      acdc07:
      CreationTime : 8/6/2018 7:23:35 AM
      LastWriteTime : 8/6/2018 7:23:35 AM
      LastAccessTime : 8/6/2018 7:20:19 AM
      acdc21:
      CreationTime : 8/6/2018 7:25:20 AM
      LastWriteTime : 8/6/2018 7:25:20 AM
      LastAccessTime : 8/6/2018 7:19:59 AM
      acdc25:
      CreationTime : 8/6/2018 7:24:42 AM
      LastWriteTime : 8/6/2018 7:24:41 AM
      LastAccessTime : 8/6/2018 7:19:48 AM
      acdc23:
      CreationTime : 8/6/2018 7:25:04 AM
      LastWriteTime : 8/6/2018 7:25:03 AM
      LastAccessTime : 8/6/2018 7:22:23 AM
      

       

      Describe steps to reproduce…

      Download a file from a Artifactory http URI

      No matter how many times you run Puppet it thinks the file is correct.  

      Desired Behavior: 

      The file is the correct file and that Puppet manages it correctly.  That it is checked each Puppet run and verified.  

      Actual Behavior:

      The file doesnt get checked locally, so its always incorrect.  The checksums dont work, so the file is always incorrect. 

       

      It would appear the md5 checksum portion of Artifactory is handled in PUP-6114 - I am not sure if the mtime portion is tracked elsewhere.  

       

        Attachments

          Activity

            jsd-sla-details-panel

              People

              • Assignee:
                josh Josh Cooper
                Reporter:
                tek0011 Jeff Sparrow
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support