Uploaded image for project: 'Puppet Agent'
  1. Puppet Agent
  2. PA-3263

Puppet Agent should ignore nssm.exe during an upgrade

    XMLWordPrintable

Details

    • Night's Watch
    • NW - 2020-06-24
    • Bug Fix
    • Hide
      Before this fix, if the puppet-agent upgrade on Windows was performed while nssm.exe was loaded by EventLog service, many services, including critical ones like dhcp/dns clients were restarted, leading to unreachable machines.

      With this commit we deliver dedicated nssm executable for pxp-agent (nssm-pxp-agent.exe) and we remove windows registry references to old nssm.exe in a WiX custom action.
      Show
      Before this fix, if the puppet-agent upgrade on Windows was performed while nssm.exe was loaded by EventLog service, many services, including critical ones like dhcp/dns clients were restarted, leading to unreachable machines. With this commit we deliver dedicated nssm executable for pxp-agent (nssm-pxp-agent.exe) and we remove windows registry references to old nssm.exe in a WiX custom action.
    • Needs Assessment

    Description

      This PR: https://github.com/puppetlabs/nssm/pull/8 updates nssm.exe to use eventcreate.exe as a log source.

      However, due to how the windows installer Install Validate works: https://docs.microsoft.com/en-us/windows/win32/msi/installvalidate-action

      Any upgrade from a version prior to 5.5.20/6.15.0 might case network outages failures.

      We should provide a new installer component for managing nssm.exe and make sure all the new installer packages ignore the old nssm.exe installer component.

      Attachments

        Issue Links

          Activity

            People

              ciprian.badescu Ciprian Badescu
              mihai.buzgau Mihai Buzgau
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support