[PA-3667] PUPPET_SERVER MSI install property doesn't work - Puppet Jira Server

XML

Word

Printable

Details

Type: Bug
Status: Resolved
Priority: Normal
Resolution: Fixed
Affects Version/s: puppet-agent 6.21.0
Fix Version/s: puppet-agent 7.7.0, puppet-agent 6.23.0
Component/s: None
Labels:
- doc-reviewed

Team:
Night's Watch
Story Points:
3
Sprint:
NW - 2021-04-28
Method Found:
Needs Assessment

Release Notes:
Bug Fix
Release Notes Summary:

Hide
Using PUPPET_SERVER as .msi property would
not set puppet server setting.
This is now fixed and puppet server is correctly set.

Show
Using PUPPET_SERVER as .msi property would not set puppet server setting. This is now fixed and puppet server is correctly set.

QA Risk Assessment:
Needs Assessment

Description

The newly added PUPPET_SERVER MSI install property doesn't seem to work:

C:\> cmd /c start /w msiexec /qn /i http://downloads.puppetlabs.com/windows/puppet6/puppet-agent-6.21.1-x64.msi PUPPET_SERVER=brisk-pop.delivery.puppetlabs.net

C:\> type C:\ProgramData\PuppetLabs\puppet\etc\puppet.conf

type C:\ProgramData\PuppetLabs\puppet\etc\puppet.conf

[main]

server=puppet

autoflush=true

manage_internal_file_permissions=false

Using PUPPET_MASTER_SERVER does work. In looking at the wix files it seems some of the custom actions and sequencing for the new property is missing some steps:

$ git --no-pager grep -e PUPPET_SERVER | grep -v PUPPET_SERVER_PORT

resources/windows/wix/customactions.wxs.erb:    <!-- PUPPET_SERVER -->

resources/windows/wix/customactions.wxs.erb:      Property="CMDLINE_PUPPET_SERVER"

resources/windows/wix/customactions.wxs.erb:      Value="[PUPPET_SERVER]"

resources/windows/wix/customactions.wxs.erb:      Value="[CMDLINE_PUPPET_SERVER]"

resources/windows/wix/sequences.wxs.erb:        CMDLINE_PUPPET_SERVER

The old setting has many more:

$ git --no-pager grep PUPPET_MASTER_SERVER

resources/windows/wix/appdatafiles.wxs:          Key="server" Value="[PUPPET_MASTER_SERVER]"

resources/windows/wix/customactions.wxs.erb:  SetPropertyFromIni "server", "INI_PUPPET_MASTER_SERVER", iniFileText

resources/windows/wix/customactions.wxs.erb:      Property="PUPPET_MASTER_SERVER"

resources/windows/wix/customactions.wxs.erb:    <!-- PUPPET_MASTER_SERVER -->

resources/windows/wix/customactions.wxs.erb:      Property="PUPPET_MASTER_SERVER"

resources/windows/wix/customactions.wxs.erb:      Value="[INI_PUPPET_MASTER_SERVER]"

resources/windows/wix/customactions.wxs.erb:      Property="CMDLINE_PUPPET_MASTER_SERVER"

resources/windows/wix/customactions.wxs.erb:      Value="[PUPPET_MASTER_SERVER]"

resources/windows/wix/customactions.wxs.erb:      Property="PUPPET_MASTER_SERVER"

resources/windows/wix/customactions.wxs.erb:      Value="[CMDLINE_PUPPET_MASTER_SERVER]"

resources/windows/wix/customactions.wxs.erb:      Property="PUPPET_MASTER_SERVER"

resources/windows/wix/properties.wxs.erb:    <Property Id="PUPPET_MASTER_SERVER">

resources/windows/wix/registryEntries.wxs.erb:            Value="[PUPPET_MASTER_SERVER]" />

resources/windows/wix/sequences.wxs.erb:      <!-- PUPPET_MASTER_SERVER -->

resources/windows/wix/sequences.wxs.erb:        INI_PUPPET_MASTER_SERVER

resources/windows/wix/sequences.wxs.erb:        CMDLINE_PUPPET_MASTER_SERVER

resources/windows/wix/sequences.wxs.erb:        PUPPET_MASTER_SERVER=""

resources/windows/wix/sequences.wxs.erb:      <!-- PUPPET_MASTER_SERVER -->

resources/windows/wix/sequences.wxs.erb:        INI_PUPPET_MASTER_SERVER

resources/windows/wix/sequences.wxs.erb:        CMDLINE_PUPPET_MASTER_SERVER

resources/windows/wix/sequences.wxs.erb:        PUPPET_MASTER_SERVER=""

resources/windows/wix/ui/PuppetInstallDirDlg.wxs:                 Text="[PUPPET_MASTER_SERVER]"

resources/windows/wix/ui/PuppetInstallDirDlg.wxs:                 Property="PUPPET_MASTER_SERVER" />

Attachments

Activity

People

Assignee:: Dorin Pleava

Reporter:: Josh Cooper

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2021/03/17 10:34 AM

Updated:: 2021/06/10 12:26 AM

Resolved:: 2021/04/28 12:15 AM