Uploaded image for project: 'Puppet Agent'
  1. Puppet Agent
  2. PA-3698

replace solaris openssl patching with compiler arguments change

    XMLWordPrintable

    Details

    • Template:
    • Team:
      Night's Watch
    • Story Points:
      1
    • Sprint:
      NW - 2021-07-14
    • Release Notes:
      Enhancement
    • Release Notes Summary:
      Hide
      This release readds the AES CTR-DRGB performance improvement to our vendored OpenSSL. The improvement was initially reverted due to compilation failures, but subsequent research showed that the failures were due to the compiler making wrong assumptions about the code, which we fixed by adding the `-mincoming-stack-boundary=2` flag during the build process.
      Show
      This release readds the AES CTR-DRGB performance improvement to our vendored OpenSSL. The improvement was initially reverted due to compilation failures, but subsequent research showed that the failures were due to the compiler making wrong assumptions about the code, which we fixed by adding the `-mincoming-stack-boundary=2` flag during the build process.
    • QA Risk Assessment:
      Needs Assessment

      Description

      In https://github.com/puppetlabs/puppet-runtime/pull/401 we removed an openssl performance patch that made openssl crash on Solaris i386.

      After investigations from OpenSSL team(https://github.com/openssl/openssl/issues/13666)  the cause was identified on the compiler side (stack pointer was not 32bits aligned). Adding  -mincoming-stack-boundary=2 argument to the compiler looks to solve the issue.

        Attachments

          Activity

            People

            Assignee:
            gabriel.nagy Gabriel Nagy
            Reporter:
            ciprian.badescu Ciprian Badescu
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support