Uploaded image for project: 'Puppet Agent'
  1. Puppet Agent
  2. PA-673

Regression in Windows puppet.conf environment setting

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: puppet-agent 1.6.0
    • Fix Version/s: None
    • Component/s: Windows
    • Labels:
      None
    • Template:
    • Team:
      Windows
    • Sprint:
      Windows Kanban
    • CS Priority:
      Normal
    • CS Frequency:
      3 - 25-50% of Customers
    • CS Severity:
      3 - Serious
    • CS Business Value:
      4 - $$$$$
    • CS Impact:
      Being able to set the environment at install time is important and this regression should be fixed.

      Description

      The Problem

      PA-286 resulted in a change such that environment=production would not end up in puppet.conf if no PUPPET_AGENT_ENVIRONMENT MSI Property was set. This is a good thing for reasons stated in that ticket.

      That fix made it in to puppet-agent version 1.5.0; however, as of version 1.6.0, the issue has come back.

      After some initial digging by Glenn Sarti, it seems the issue may have popped back in at https://github.com/puppetlabs/puppet-agent/commit/0495e5db06cec78d1bd597497c751e81fbf5e803

      The Desired Behavior

      • On a fresh install with PUPPET_AGENT_ENVIRONMENT not specified, puppet.conf does not have an environment key.
      • On a fresh install with PUPPET_AGENT_ENVIRONMENT=foo specified, puppet.conf does have a key of environment=foo.
      • On an upgrade where puppet.conf has an environment key, the value stays the same.
      • On an upgrade where puppet.conf does not have an environment key, the key remains out of puppet.conf.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ethan Ethan Brown
              Reporter:
              nate.mccurdy Nate McCurdy
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support