Uploaded image for project: 'Puppet Agent'
  1. Puppet Agent
  2. PA-768

The Windows MSI should not remove the EventLog message DLL and registry entries

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Duplicate
    • Affects Version/s: puppet-agent 1.8.2
    • Fix Version/s: puppet-agent 1.10.0
    • Component/s: Windows
    • Labels:
      None
    • Template:
    • Acceptance Criteria:
      Hide

      The puppetres.dll file and associated registry entries (SYSTEM\CurrentControlSet\services\eventlog\Application\Puppet\......) should not be removed on uninstall.

      Show
      The puppetres.dll file and associated registry entries (SYSTEM\CurrentControlSet\services\eventlog\Application\Puppet\......) should not be removed on uninstall.
    • Team:
      Night's Watch
    • Story Points:
      3
    • Sprint:
      AP 2017-02-08, AP 2017-02-22, AP 2017-03-08, Agent 2017-03-22, PR - Triage
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      In rare circumstances, upgrading the Puppet Agent on Windows may restart seemingly unrelated Windows services. The Event Log service can hold locks on the Puppet event log message DLL when PowerShell or other log parsing tools have the event log open, which is the cause of this problem. Since Windows often hosts multiple services in the same process, restarting the Event Log service will cause all co-hosted services to be restarted at the same time - depending on what these are, it may cause a cascade of dependent services to restart. After installing this (or any newer) version of the agent, Puppet will not attempt to replace the locked Event Log message DLL, avoiding restarts of the Event Log service.
      Show
      In rare circumstances, upgrading the Puppet Agent on Windows may restart seemingly unrelated Windows services. The Event Log service can hold locks on the Puppet event log message DLL when PowerShell or other log parsing tools have the event log open, which is the cause of this problem. Since Windows often hosts multiple services in the same process, restarting the Event Log service will cause all co-hosted services to be restarted at the same time - depending on what these are, it may cause a cascade of dependent services to restart. After installing this (or any newer) version of the agent, Puppet will not attempt to replace the locked Event Log message DLL, avoiding restarts of the Event Log service.
    • QA Risk Assessment:
      Automate
    • QA Risk Assessment Reason:
      Customer escalation warrants a test

      Description

      When the Windows MSI uninstalls, it also uninstalls the Event Log Message DLL and the appropriate registry entries. This can cause the Puppet eventlog entries to look strange in event viewer and event log tools.

      The puppetres.dll file and associated registry entries (SYSTEM\CurrentControlSet\services\eventlog\Application\Puppet\......) should not be removed on uninstall.

      Component Table - https://msdn.microsoft.com/en-us/library/windows/desktop/aa368007(v=vs.85).aspx - msidbComponentAttributesPermanent

      Wix Component Element - http://wixtoolset.org/documentation/manual/v3/xsd/wix/component.html

      The registry entries are part of the RegistryEntries component. This should be split out into their own component and then marked as permanent

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              glenn.sarti Glenn Sarti
              Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support