Uploaded image for project: 'Puppet Communications Protocol'
  1. Puppet Communications Protocol
  2. PCP-714

Closing connection in on-connect callback sometimes causes 1006 on client

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Normal
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Template:
    • QA Risk Assessment:
      Needs Assessment

      Description

      Closing the connection in the on-connect callback - which we do when authorization for association rejects the connection - sometimes results in the client getting a 1006 response, meaning the connection was not closed cleanly. https://github.com/puppetlabs/pcp-broker/pull/171 works around this issue in testing.

      We could try to improve this by peeling some of the abstraction from trapperkeeper jetty around websocket handling upgrade requests at https://github.com/puppetlabs/trapperkeeper-webserver-jetty9/blob/1.7.0/src/puppetlabs/trapperkeeper/services/webserver/experimental/jetty9_websockets.clj#L119-L123. It would make sense to handle rejection there, in the upgrade request.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            michael.smith Michael Smith
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:

                Zendesk Support