[PCP-833] pxp-agent init script will start more than one process if pidfile is missing - Puppet Jira Server

XML

Word

Printable

CS Priority:
Normal
CS Frequency:
1 - 1-5% of Customers
CS Severity:
2 - Annoyance
CS Business Value:
4 - $$$$$
CS Impact:
Unclear the impact of this beyond two running processes. More information needed on the impact of this. Does the broker flap between them? Do commands get executed twice? How does it end up without the PIDfile in the first place?
Zendesk Ticket IDs:
34307
Zendesk Ticket Count:
1

Release Notes:
Bug Fix
Release Notes Summary:
This modifies the pxp-agent service to kill all pxp-agent processes when the service is restarted, rather than just the current pxp-agent process.

OS / Version: Confirmed in Centos 6.7 and SLES 11

/opt/puppetlabs/puppet/bin/pxp-agent --version

 1.8.1

#pxp-agent process running normally:

service pxp-agent status

 pxp-agent (pid 16099) is running...

rm /var/run/puppetlabs/pxp-agent.pid

service pxp-agent start

 Starting PXP agent: [ OK ]

ps aux | grep pxp-agent | grep -v grep

root 16099 1.6 0 1 379536 9776 ? Sl 21:21 0:02 /opt/puppetlabs/puppet/bin/pxp-agent

root 16297 9.9 0.0 379536 7744 ? Sl 21:23 0:02 /opt/puppetlabs/puppet/bin/pxp-agent

The init script should only allow one running pxp-agent process

With a missing pidfile the init script will start another pxp-agent process

relates to

PCP-862 pxp-agent connection flapping exhausts resources on broker

MODULES-8533 Windows upgrades are failing due to pxp-agent issues