Uploaded image for project: 'PuppetDB'
  1. PuppetDB
  2. PDB-1026

Remove call to_pson from catalog submission

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PDB 3.0.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Story Points:
      2
    • Sprint:
      PuppetDB 2015-01-28, PuppetDB 2015-02-11, PuppetDB 2015-02-25

      Description

      We have still been using to_pson in our catalog submission in the terminus, and we should switch this to using to_json. This might allow us to remove some of the funny unicode stripping we do also. It comes with some risk, worth doing in a 3.0.0 release if possible as it might change behaviour, so I'm marking it as such.

      The biggest work I see here is in the unicode stuff, and making sure we don't mess that up. Test coverage for this case, and a thorough understanding of this code is essential for this work I think. We need to understand the full change here and what it means in a unicode world.

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  andrew.roetker AJ Roetker
                  Reporter:
                  ken Ken Barber
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: