PR (166): Allow db management to be disabled - rfletcher

Allow db management to be disabled

• Author: Rick Fletcher <fletch@pobox.com>
• Company:
• Github ID: rfletcher
• Pull Request 166 Discussion
• Pull Request 166 File Diff

Pull Request Description

I'm configuring PuppetDB to connect to a third-party remote DB (Amazon RDS), so I've set `$manage_server` to `false`. That lead to this error from the Postgresql module (because the server isn't in my catalog):

> Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Invalid relationship: Postgresql_psql[Check for existence of db 'puppetdb']

, because Class[Postgresql::Server::Service] doesn't seem to be in the catalog

After digging in I found that despite disabling `$manage_server`, the module still tries to create the db/user.

I would probably have argued that `$manage_server` should affect db/user management too, but in the interest of backward compatibility I've instead added a new option to manage that independently (`$manage_db`), and preserved the current behavior by default.

(webhooks-id: 0f9dc5ec8f3f3f036b2c094b3c3d57c0)