Uploaded image for project: 'PuppetDB'
  1. PuppetDB
  2. PDB-1228

investigate a paging solution for multi-row responses

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PDB 3.0.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Story Points:
      3
    • Sprint:
      PuppetDB 2015-02-25, PuppetDB 2015-03-11, PuppetDB 2015-03-25, PuppetDB 2015-04-08

      Description

      Currently we jump through some hoops to implement limit and offset for reports and factsets:

      https://github.com/puppetlabs/puppetdb/blob/master/src/puppetlabs/puppetdb/jdbc.clj#L177-209

      Catalogs should have the same issue, but it doesn't because it hasn't been implemented (see PDB-1083)

      The way we're doubling up the queries ruins the streaming response, so the approach is not performant at scale. We need to think of a better way to implement this.

      Part of a solution could be to push top-level extract down to database so resource-events can be toggled in the reports response. This would not solve the issue with factsets but would get the problem off the reports endpoint. There also may be something we can do using postgres window functions – needs more exploration.

        Attachments

          Activity

            jsd-sla-details-panel

              People

              • Assignee:
                Unassigned
                Reporter:
                wyatt Wyatt Alt
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: