Uploaded image for project: 'PuppetDB'
  1. PuppetDB
  2. PDB-1241

Resource event timestamps should be normalized

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PDB 3.0.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently we take the resource event timestamps as a string and store it in the (timestamp) database field for the resource event. This leads to two odd things. The first is that two timestamps that are the same but represented differently (i.e. one uses Z, the other -0000 etc) to hash differently. Although this should not happen when Puppet sends us data, if the data comes in as another timezone, although it's stored in that timezone, it is convert to UTC on the way out. We had some tests doing this which was pretty confusing.

      Other timestamps, such as start_time and end_time of the report do get normalized, we just need to do the same thing with resource events.

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  ryan.senior Ryan Senior
                  Reporter:
                  ryan.senior Ryan Senior
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: